Chore/contextual errors for table editor #39004
Merged
+186
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
6 Skipped Deployments
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
joshenlim
commented
Sep 25, 2025
| throw new Error( | ||
| `Error fetching table rows: ${error instanceof Error ? error.message : 'Unknown error'}` | ||
| ) | ||
| throw new Error(error instanceof Error ? error.message : 'Unknown error') |
There was a problem hiding this comment.
The prefix here should be handled on the component that's consuming the error
|
Studio E2E Results
Artifacts: https://github.com/supabase/supabase/actions/runs/18009239922 Last updated: Thursday 25, September, 2025 14:04:05 (UTC) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
On the topic of enabling users to self debug issues, opting to provide contextual errors in the table editor especially when applying filters.
A common issue users run into is when providing a filter value that doesn't match the column data type, understandably with the current error UI it looks like it's something wrong with the dashboard. Opting to show actionable feedback to users when running into errors - we can incrementally expand this (We've already got one for foreign tables).
Before
Changes involved
retryto false when fetching table rows