fix(studio): refetch GitHub repositories after new install #39021
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
|
Studio E2E Results
Artifacts: https://github.com/supabase/supabase/actions/runs/18055278634 Last updated: Saturday 27, September, 2025 05:07:42 (UTC) |
avallete
changed the title
|
|
||
| const GITHUB_ICON = ( | ||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 98 96" className="w-6"> | ||
| <title>GitHub icon</title> |
There was a problem hiding this comment.
note
Svg must have a title in it (biome says)
| const refetchGitHubAuthorizationAndRepositories = () => { | ||
| setTimeout(() => { | ||
| refetchGitHubAuthorization() | ||
| refetchGitHubRepositories() | ||
| }, 2000) // 2 second to delay to let github authorization and repositories to be updated | ||
| } |
There was a problem hiding this comment.
note:
Github api takes ~2s per testing to acknowledge changes, retrying the query after 2s allows the pop-up to update with the latest repositories without the need to interact / search over the pop-up.
| const [isConfirmingRepoChange, setIsConfirmingRepoChange] = useState(false) | ||
| const [repoComboBoxOpen, setRepoComboboxOpen] = useState(false) | ||
| const isParentProject = !Boolean(selectedProject?.parent_project_ref) | ||
| const isParentProject = !selectedProject?.parent_project_ref |
There was a problem hiding this comment.
note:
Unnecessary boolean.
| branchName: val.branchName, | ||
| }) | ||
| } catch (error) { | ||
| } catch { |
| if (error) handleError(error) | ||
| // [Alaister]: temp fix until we have a proper response type | ||
| return (data as any).repositories | ||
| return data.repositories |
There was a problem hiding this comment.
note
This is now properly typed.
| if (closeCallback) { | ||
| // Poll to check if window is closed | ||
| const checkClosed = setInterval(() => { | ||
| if (newWindow.closed) { | ||
| clearInterval(checkClosed) | ||
| closeCallback() | ||
| } | ||
| }, 500) // Check every 500ms | ||
|
|
||
| // Add a timeout to prevent infinite polling | ||
| setTimeout(() => { | ||
| clearInterval(checkClosed) | ||
| }, 300000) // 5 minutes timeout | ||
| } |
There was a problem hiding this comment.
note
This trick allow to trigger refetch when the pop-up is closed after installation.
avallete
deleted the
fix/refetch-github-repositories-after-new-install
branch
What kind of change does this PR introduce?