Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP / POC — [Feature] theming / customization #241

Closed
wants to merge 11 commits into from

Conversation

MildTomato
Copy link
Contributor

@MildTomato MildTomato commented Jul 3, 2021

to do:

  • allow for override of styles if ThemeProvider is being used
  • add a config wrapper for target app to use for purging either default theme file, or custom theme file

I'm trying to look at removing css modules completely

we could also look at leaving in some css class names purely for the same of making it easier for a developer to target elements if they need to override something with css rather than tailwind classes.

@MildTomato MildTomato mentioned this pull request Jul 3, 2021
@MildTomato MildTomato changed the title WIP / RFC — [Feature] theming / customization WIP / POC — [Feature] theming / customization Jul 3, 2021
• Alert
• Accordion
• Badge
@MildTomato MildTomato linked an issue Aug 18, 2021 that may be closed by this pull request
Base automatically changed from develop to master September 14, 2021 14:45
@willopez
Copy link

@MildTomato This theming feature would be very useful, is this still planed for sometime in the future? in the mean time, I guess forking and changing the theme would be the way to customize?

@MildTomato
Copy link
Contributor Author

MildTomato commented Aug 18, 2022

@willopez yep it is. I did a first pass on it in alpha brach but I wasn't happy with it.
I want to change it so the tailwind classes are more explicit. like bg-panel-primary, rather than bg-gray-300.
Then it would be much easier to customize.

It also creates way too many css properties currently as well, so I also want to fix that up really.

@willopez
Copy link

OK, got it. And I agree that making class names explicit will make it easier to customize. I am open to help with this effort, how can I help?

@MildTomato
Copy link
Contributor Author

@willopez honestly, and this will sound boring.. possibly branching off alpha branch and basically going through all the classNames in the theme file and renaming them all to be explicit.

I'm not that sure what the structure could be yet, although I've started planning it a little bit in Figma and I have the following names for things. But it's a bit of a work in progress.

@MildTomato
Copy link
Contributor Author

Saying that, the name/structure in that figma tokens json isn't very useful.
As we'll probably want to keep to using tailwind standard of naming things - so flipping it.

So form.input.error.bg would be bg-form-input-error

I'm still not entirely sure this is a good idea, as we'll end up with a lot of classes.
Something else could be using arbitary class names and read from css properties.

Like, bg-[var(--form-input-error-bg)]

@MildTomato
Copy link
Contributor Author

Supabase UI is being deprecated.

As part of that, we are closing Pull Requests in this repo for now.


We are moving the components to the main mono repo at https://github.com/supabase/supabase.

The auth component has been moved to it's own repo and package. https://github.com/supabase-community/auth-ui. You can also read the docs for auth ui here.

@MildTomato MildTomato closed this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants