This repository was archived by the owner on Feb 19, 2025. It is now read-only.
Fix/button fixes #32
Merged
Fix/button fixes #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… depending on size of button. Icon sizes can still be overridden though. #29
This was
linked to
issues
Jan 7, 2021
both icons are hidden with `loading` is true
|
🎉 This PR is included in version 0.1.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
fix: fix
childrenerror in Transition in Button componentchore: remove sizeClasses as its not needed
fix: added context consumer and provider to inject icon size
chore: tidy Icon component code
chore: migrate from JS to TS
chore: improve
dangerstyling of buttonschore: add
iconRightinline prop tochore: add
sizedefault to component