Skip to content

feat: add time data type support #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat: add time data type support #402

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion supabase-wrappers/src/interface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
use crate::instance::ForeignServer;
use crate::FdwRoutine;
use pgrx::pg_sys::panic::ErrorReport;
use pgrx::prelude::{Date, Interval, Timestamp, TimestampWithTimeZone};
use pgrx::prelude::{Date, Interval, Time, Timestamp, TimestampWithTimeZone};
use pgrx::{
datum::Uuid,
fcinfo,
Expand Down Expand Up @@ -45,6 +45,7 @@ pub enum Cell {
Numeric(AnyNumeric),
String(String),
Date(Date),
Time(Time),
Timestamp(Timestamp),
Timestamptz(TimestampWithTimeZone),
Interval(Interval),
Expand Down Expand Up @@ -73,6 +74,7 @@ impl Clone for Cell {
Cell::Numeric(v) => Cell::Numeric(v.clone()),
Cell::String(v) => Cell::String(v.clone()),
Cell::Date(v) => Cell::Date(*v),
Cell::Time(v) => Cell::Time(*v),
Cell::Timestamp(v) => Cell::Timestamp(*v),
Cell::Timestamptz(v) => Cell::Timestamptz(*v),
Cell::Interval(v) => Cell::Interval(*v),
Expand Down Expand Up @@ -128,6 +130,17 @@ impl fmt::Display for Cell {
dt_cstr.to_str().expect("date should be a valid string")
)
},
Cell::Time(v) => unsafe {
let ts =
fcinfo::direct_function_call_as_datum(pg_sys::time_out, &[(*v).into_datum()])
.expect("cell should be a valid time");
let ts_cstr = CStr::from_ptr(ts.cast_mut_ptr());
write!(
f,
"'{}'",
ts_cstr.to_str().expect("time hould be a valid string")
)
},
Cell::Timestamp(v) => unsafe {
let ts = fcinfo::direct_function_call_as_datum(
pg_sys::timestamp_out,
Expand Down Expand Up @@ -198,6 +211,7 @@ impl IntoDatum for Cell {
Cell::Numeric(v) => v.into_datum(),
Cell::String(v) => v.into_datum(),
Cell::Date(v) => v.into_datum(),
Cell::Time(v) => v.into_datum(),
Cell::Timestamp(v) => v.into_datum(),
Cell::Timestamptz(v) => v.into_datum(),
Cell::Interval(v) => v.into_datum(),
Expand Down Expand Up @@ -230,6 +244,7 @@ impl IntoDatum for Cell {
|| other == pg_sys::NUMERICOID
|| other == pg_sys::TEXTOID
|| other == pg_sys::DATEOID
|| other == pg_sys::TIMEOID
|| other == pg_sys::TIMESTAMPOID
|| other == pg_sys::TIMESTAMPTZOID
|| other == pg_sys::INTERVALOID
Expand Down Expand Up @@ -281,6 +296,9 @@ impl FromDatum for Cell {
PgOid::BuiltIn(PgBuiltInOids::DATEOID) => {
Date::from_datum(datum, is_null).map(Cell::Date)
}
PgOid::BuiltIn(PgBuiltInOids::TIMEOID) => {
Time::from_datum(datum, is_null).map(Cell::Time)
}
PgOid::BuiltIn(PgBuiltInOids::TIMESTAMPOID) => {
Timestamp::from_datum(datum, is_null).map(Cell::Timestamp)
}
Expand Down
Loading