fix: fix getting jwt signing keys with mongodb #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhpoddar
added a commit
that referenced
this pull request
Apr 5, 2023
* feat: adding new access token version and BE controlled dynamic/static key signing * feat: finishing jwt-to-access token + tests * refactor: adding/using a semver class instead of version strings * refactor: update/fix cdi version handling * refactor: adding/using a semver class instead of version strings (#576) * adds foreign key constraint to in mem db * refactor: adding/using a semver class instead of version strings * refactor: review comments * refactor: cleaned up code, added convenience functions & tests --------- Co-authored-by: rishabhpoddar <rishabh.poddar@gmail.com> * refactor: fix review comments * refactor: remove unused constructor * feat: add checkDatabase to session verification API * feat: add an overlap time to generate dynamic signing keys before use * docs: update comments based on review feedback * chore: update plugin interface version * test: fix tests * chore: update changelog * chore: add deprecation notice * fix: remove unused code * refactor: fix review comments * chore: update changelog * fix: add NOT NULL to use_static_key for in-memory db as well * chore: fix table name in migration instructions in the changelog * feat: rename useStaticSigningKey param and expand testing (#588) * feat: make refresh api return unauthorised on AccessTokenPayloadError (#590) * feat: make refresh api return unauthorised on AccessTokenPayloadError * fix: create/sign legacy sessions with the appropriate key * fix: minor consistency fixes (#617) * refactor: update CDI version number * fix: fix getting jwt signing keys with mongodb (#623) * test: update tests after merge * feat: make old config name still work for backwards compatibility (mainly testing) * refactor: update CDI version * chore: update version number * test: remove some checks that are no longer correct --------- Co-authored-by: rishabhpoddar <rishabh.poddar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
fix: fix getting jwt signing keys with MongoDB (already existing in master)
Related issues
Test Plan
Added test that creates 2 JWTs, ensuring we have a key created before we sign the second one
Documentation changes
N/A
Checklist for important updates
coreDriverInterfaceSupported.jsonfile has been updated (if needed)pluginInterfaceSupported.jsonfile has been updated (if needed)build.gradlegetPaidFeatureStatsfunction in FeatureFlag.java filebuild.gradle, please make sure to add themin
implementationDependencies.json.git tag) in the formatvX.Y.Z, and then find thelatest branch (
git branch --all) whoseX.Yis greater than the latest released tag.