Skip to content

Conversation

porcellus
Copy link
Collaborator

@porcellus porcellus commented Apr 5, 2023

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your
changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here
highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
    • If there are any db schema changes, mention those changes clearly
  • coreDriverInterfaceSupported.json file has been updated (if needed)
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • If added a new paid feature, edit the getPaidFeatureStats function in FeatureFlag.java file
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them
    in implementationDependencies.json.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the
      latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

  • Item1
  • Item2

porcellus and others added 30 commits January 30, 2023 10:01
* adds foreign key constraint to in mem db

* refactor: adding/using a semver class instead of version strings

* refactor: review comments

* refactor: cleaned up code, added convenience functions & tests

---------

Co-authored-by: rishabhpoddar <rishabh.poddar@gmail.com>
…#590)

* feat: make refresh api return unauthorised on AccessTokenPayloadError

* fix: create/sign legacy sessions with the appropriate key
@porcellus porcellus changed the base branch from 4.6 to 5.0 April 5, 2023 13:11
@rishabhpoddar rishabhpoddar merged commit c5bddf9 into 5.0 Apr 5, 2023
@rishabhpoddar rishabhpoddar deleted the feat/access_token_to_jwt_base branch April 5, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants