add snapshot test for syntax highlight grammar #1391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto grammar-test
jasonlyu123
commented
Feb 23, 2022
| "vscode:prepublish": "npm run build && npm prune --production", | ||
| "watch": "npm run build:grammar && tsc -w -p ./", | ||
| "test": "echo 'NOOP'" | ||
| "test": "npm run build:grammar && node test/grammar/test.js" |
There was a problem hiding this comment.
The reason for this test.js script is that we can just read the dummy directory to build the argument list instead of having to write a big long list in the package.json
dummdidumm
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
Awesome 🎉 This will help us greatly to adjust the grammar in the future and not having to worry about regressions - so much better than having a manual look at all the colors.
I think the tests cover the syntax pretty well, we can always add more if we run into something.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the test setup is adapted from vscode-ng-language-service. Might also have to add some edge cases we fixed before.