Skip to content

fix menu dead zone #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix menu dead zone #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/site-kit/src/lib/components/Banner.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
display: initial;
}

@media (min-width: 800px) {
@media (min-width: 832px) {
.banner {
top: initial;
bottom: 0;
Expand Down
10 changes: 5 additions & 5 deletions packages/site-kit/src/lib/components/Shell.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,15 +51,15 @@ The main shell of the application. It provides a slot for the top navigation, th
main {
position: relative;
margin: 0 auto;
padding-top: var(--sk-nav-height);
padding-bottom: var(--sk-banner-height);
padding-top: var(--sk-banner-height);
padding-bottom: 0;
height: 100%;
}

@media (max-width: 799px) {
@media (min-width: 832px) {
main {
padding-top: var(--sk-banner-height);
padding-bottom: 0;
padding-top: var(--sk-nav-height);
padding-bottom: var(--sk-banner-height);
}
}
</style>
28 changes: 0 additions & 28 deletions packages/site-kit/src/lib/docs/DocsContents.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,32 +109,6 @@
margin: 0;
}

@media (max-width: 831px) {
.sidebar {
padding: 1rem;
padding-top: 1rem;
}

li {
margin-bottom: 2.5rem;
}

a {
border-radius: var(--sk-border-radius);
line-height: 1;
vertical-align: center;
padding: 0.9rem 0.75rem !important;
transition: 0.1s ease;
transition-property: background-color, color;
}

a:hover {
text-decoration: none;

background-color: var(--sk-back-4);
}
}

@media (min-width: 832px) {
.sidebar {
columns: 1;
Expand Down Expand Up @@ -163,8 +137,6 @@
z-index: 2;
position: absolute;
rotate: 45deg;
/** needed to synchronise with transition on `*` in `base.css` */
transition: background-color 0.5s var(--quint-out);
box-shadow: 0 0 3px rgba(0, 0, 0, 0.12);
}
}
Expand Down
6 changes: 3 additions & 3 deletions packages/site-kit/src/lib/nav/Nav.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ Top navigation bar for the application. It provides a slot for the left side, th
font: var(--sk-font-ui-medium);
}

@media (max-width: 799px) {
@media (max-width: 831px) {
nav {
transition: transform 0.2s;
}
Expand Down Expand Up @@ -305,7 +305,7 @@ Top navigation bar for the application. It provides a slot for the left side, th
display: block;
}

@media (max-width: 799px) {
@media (max-width: 831px) {
nav {
top: unset;
bottom: 0;
Expand Down Expand Up @@ -337,7 +337,7 @@ Top navigation bar for the application. It provides a slot for the left side, th
}
}

@media (min-width: 800px) {
@media (min-width: 832px) {
.home-link {
--padding-right: 2rem;
width: 13.2rem;
Expand Down
3 changes: 0 additions & 3 deletions packages/site-kit/src/lib/nav/NavContextMenu.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,7 @@
a {
display: flex;
align-items: center;
border-radius: var(--sk-border-radius);
color: var(--sk-text-2);
transition: 0.1s ease;
transition-property: background-color, color;

&[aria-current='page'] {
color: var(--sk-theme-1) !important;
Expand Down
Loading