Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Allow all extensions in links #619

Closed
wants to merge 1 commit into from

Conversation

tshort
Copy link

@tshort tshort commented Jan 8, 2023

It's nice to be able to link to more types of files than the default. That could be code (py, js, sh), data (csv), configuration files (yaml), or anything else.

This fixes #592 and #593.

I've tried this out, and it works well. It's WIP because:

  • If this approach is desired, the extension code probably needs some work. There's no need for otherExts. The code could treat extensions as one of: markdown, images, and everything else.

  • I assume tests need to be update.

@svsool
Copy link
Owner

svsool commented Jan 14, 2023

Hi @tshort, currently all extensions are not allowed for performance reasons (workspace cache is rebuilt on restart), for example, there could be users where knowledge base is located next to deeply nested folders like node_modules with lots of files. Another suggestion could be to allow custom extensions to be configurable via settings or if all are needed allow a wildcard like *.

@tshort
Copy link
Author

tshort commented Jan 14, 2023

I'll play around with configurable options.

@tshort tshort closed this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all extensions are open with default app
2 participants