Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a configuration option for other file extensions #621

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tshort
Copy link

@tshort tshort commented Jan 27, 2023

This option allows the user to specify a list of "other" file extensions. These are in addition to Markdown and image files. This is an array. For the special case of ["*"], all files are supported, regardless of extension.

This partially fixes requests in #592 and #593.

I took a shot at a test, but I can't figure out how to run tests locally, so I don't know if it works. This option also needs to be documented.

@svsool
Copy link
Owner

svsool commented Jan 28, 2023

Thanks for contributing @tshort!

I took a shot at a test, but I can't figure out how to run tests locally, so I don't know if it works. This option also needs to be documented.

Let me know if this approach works for you: https://github.com/svsool/memo/blob/master/CONTRIBUTING.md#run-tests

package.json Outdated Show resolved Hide resolved
@tshort
Copy link
Author

tshort commented Feb 5, 2023

I've tried a few things, but I can't get yarn test to work. I'm seeing "Cannot find module '_isMockFunction'". Is there some extension I need to add?

Also, it doesn't look like the CI is running for this PR (Secret VSCE_PAT is required, but not provided while calling). Is there anything I need to do to enable that?

@svsool
Copy link
Owner

svsool commented Feb 19, 2023

I've tried a few things, but I can't get yarn test to work. I'm seeing "Cannot find module '_isMockFunction'". Is there some extension I need to add?

Also, it doesn't look like the CI is running for this PR (Secret VSCE_PAT is required, but not provided while calling). Is there anything I need to do to enable that?

Checked this locally as well and indeed there is an issue with tests in latest vscode version that will need some investigation.

Update: After some investigation I found that commenting this code makes tests run (needs a proper fix though), seems like require logic in latest vscode changed.

@svsool
Copy link
Owner

svsool commented Mar 4, 2023

Hi @tshort, tests should be fixed now, please rebase, update NodeJS to v16.14.2, reinstall packages and let me know if works.

I'd suggest also to add tests for ["*"] and [] cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants