[akka-scala] template upgrade dependency version and refactor #7172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shijinkui thanks for the PR. |
ramzimaalej
suggested changes
Dec 13, 2017
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> |
There was a problem hiding this comment.
Why have some of the maven plugins been removed (i.e enforcer plugin has been removed?)
| <joda-time-version>2.2</joda-time-version> | ||
| <swagger-core-version>1.5.15</swagger-core-version> | ||
| <maven-plugin.version>1.0.0</maven-plugin.version> | ||
| <properties> |
There was a problem hiding this comment.
Please update the dependencies in build.gradle and build.sbt as well
There was a problem hiding this comment.
Please update the dependencies in build.gradle and build.sbt as well
Done. But there is no build.gradle.mustache in akka-scala
|
LGTM @wing328 |
|
@ramzimaalej thanks for reviewing. @shijinkui thanks for the enhancement. |
wing328
changed the title
4 tasks
wing328
pushed a commit
that referenced
this pull request
Dec 21, 2017
slarti-b
added a commit
to slarti-b/swagger-codegen
that referenced
this pull request
Dec 26, 2017
* master: move bvwells to go tech comm update current stable version in readme skip push snapshot to avoid error comment out checkstyle in circleci pom.xml comment out check style plugin Revert "update version to 2.4.0-SNAPSHOT" update ci config to install codegen locally update doc to 2.3.0 update version to 2.4.0-SNAPSHOT update version to 2.3.0 fix net35 with JsonSubTypes (swagger-api#7043) [Javascript] Set ES5 as default (swagger-api#7239) swagger-api#7201: Take the modelPropertyNaming property into account again (swagger-api#7202) add trenneman as elm creator add bvwells to go technical committee Video "Building an API with Swagger" (swagger-api#7237) [Akka-Scala] This is a fix to a bug introduced by this PR swagger-api#7172 (swagger-api#7228) Add Elm language - BETA (swagger-api#6947) bump stack resolver to lts-10.0 (swagger-api#7221)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
closes #7171