Skip to content

Conversation

InPermutation
Copy link
Contributor

3 changes, in decreasing order of importance:

  • Heroku automatically sends you to the HTTPS version of the app when you install with Heroku Button.
    Then, Firefox (since version 23) blocks the download of Reenie Beanie, and apparently replaces it with Comic Sans MS?!
  • The changes in README.md are mostly irrelevant because of https://help.github.com/articles/why-do-my-images-have-strange-urls/, but it's good practice, in case it ends up getting rendered somewhere that isn't GitHub.
  • I'm not sure if the Placekitten one is even viewable from a browser -- I didn't bother checking. The HTTPS version of the resource does load, however, so it probably won't break anything.

Koronen added a commit that referenced this pull request Aug 12, 2015
use TLS for external resources
@Koronen Koronen merged commit 527491d into stringer-rss:master Aug 12, 2015
@Koronen
Copy link
Contributor

Koronen commented Aug 12, 2015

Thanks @InPermutation!

@InPermutation InPermutation deleted the tls branch August 12, 2015 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants