Show specific error messages #19
Comments
|
@swapagarwal Have you got any ideas on how to resolve this? I'm thinking of adding a output['error_msg'] in every module's output variable and have it populated with the equivalent error message within the respective modules itself. Like say, the query is
I sent and just like #43 it throws an error. So now what I'll do, I'll add an additional entry to This would ensure our commitment towards a "beginners entry" code standard with no additional logic to be added into. Edit: This message would later be shown in the search.py (line 33) of the modules directory instead of the current one. Let me know if you like it so that I can begin implementing this to all our modules. |
|
@shanmukhateja It's like you read my mind! |
|
Haha so should I PR the dictionary module first? Come on..let me do them all! |
|
btw, how many modules need this? let's first list them down. |
|
I think it's required for all the modules because errors can occur for all modules |
|
Agreed, except the basic ones like help, request, etc. |
ghost
mentioned this issue
# This is the 1st commit message: Added more tests to test_anime # This is the commit message swapagarwal#2: Changed Hummingbird API to Kitsu # This is the commit message swapagarwal#3: Added bad query test to test_anime # This is the commit message swapagarwal#4: Based slice length on len # This is the commit message swapagarwal#5: Removed repeated searches. # This is the commit message swapagarwal#6: Broke tests into different functions. # This is the commit message swapagarwal#7: Removed whitespace. # This is the commit message swapagarwal#8: Added tests based on API response and rating format. # This is the commit message swapagarwal#9: Reorganized some calls. # This is the commit message swapagarwal#10: Refactored API requests, added tests for rank and episode count # This is the commit message swapagarwal#11: Added another test case. # This is the commit message swapagarwal#12: Added tests for kitsu and youtube links # This is the commit message swapagarwal#13: Stickler corrections. # This is the commit message swapagarwal#14: More Stickler corrections. # This is the commit message swapagarwal#15: More Stickler corrections. # This is the commit message swapagarwal#16: Stickler corrections. # This is the commit message swapagarwal#17: Moved declarations closer to point used. # This is the commit message swapagarwal#18: Style corrections. # This is the commit message swapagarwal#19: Style correction
Right now, whenever an error occurs, a generic error message (
something didn't work as expected) is displayed to the user, who can't determine what went wrong!The text was updated successfully, but these errors were encountered: