-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a curated list of jokes #4
Comments
Hi, I'd like to contribute to this repo.. Please let me know if I can contribute :) |
You are welcome to contribute! |
Hi what should be the deciding factor if a joke should be delivered by the API call or from the pre-compiled list within JARVIS? |
If we can hand-pick a minimum number (say 10-15) of funny jokes, then we'd remove the API call. |
But don't you think it would be just repeatedly showing these 10-15 only? I think we should make use of both of them. |
Also I propose we use a jokes.txt file for this list. |
Those 10-15 can be expanded with time. |
Understood. I'll submit some 10-15 for starters. We can expand later :) |
|
I put a \t\t\t between the joke as a syntax for handling Q&A model jokes. |
@shanmukhateja You can send a PR and then we can take the discussion over there. 😄 |
See #4 * improve jokes module * migrated to json format
Now that this is resolved, shouldn't we close this issue @swapagarwal ? |
I'd like to keep this open for newbies to get started with (by adding some more jokes). 😄 |
well then they can open a new one right? Like referencing the same issue multiple times for different commits by different ppl isn't much convincing |
They can just open a new issue later ;) |
Yepp, they can open a new one but keeping this open would encourage new people to start contributing! |
Continued in #54 |
# This is the 1st commit message: Added more tests to test_anime # This is the commit message swapagarwal#2: Changed Hummingbird API to Kitsu # This is the commit message swapagarwal#3: Added bad query test to test_anime # This is the commit message swapagarwal#4: Based slice length on len # This is the commit message swapagarwal#5: Removed repeated searches. # This is the commit message swapagarwal#6: Broke tests into different functions. # This is the commit message swapagarwal#7: Removed whitespace. # This is the commit message swapagarwal#8: Added tests based on API response and rating format. # This is the commit message swapagarwal#9: Reorganized some calls. # This is the commit message swapagarwal#10: Refactored API requests, added tests for rank and episode count # This is the commit message swapagarwal#11: Added another test case. # This is the commit message swapagarwal#12: Added tests for kitsu and youtube links # This is the commit message swapagarwal#13: Stickler corrections. # This is the commit message swapagarwal#14: More Stickler corrections. # This is the commit message swapagarwal#15: More Stickler corrections. # This is the commit message swapagarwal#16: Stickler corrections. # This is the commit message swapagarwal#17: Moved declarations closer to point used. # This is the commit message swapagarwal#18: Style corrections. # This is the commit message swapagarwal#19: Style correction
The API call in the
joke
module can be prevented by adding a curated list of jokes in the source file itself.Pros:
Con:
The text was updated successfully, but these errors were encountered: