Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a curated list of jokes #4

Closed
swapagarwal opened this issue Apr 21, 2016 · 17 comments
Closed

Add a curated list of jokes #4

swapagarwal opened this issue Apr 21, 2016 · 17 comments
Labels
help wanted Improvement Low-Hanging Fruit

Comments

@swapagarwal
Copy link
Owner

swapagarwal commented Apr 21, 2016 •
edited
Loading

The API call in the joke module can be prevented by adding a curated list of jokes in the source file itself.
Pros:

  • Fewer API calls
  • Curated jokes (only include the ones that tickle your funny bone)
  • No offensive jokes (sometimes the API returns such type of jokes)

Con:

  • The curation effort (only one time!)
@swapagarwal swapagarwal changed the title Prevent unnecessary API call Add a curated list of jokes Apr 21, 2016
@havanagrawal
Copy link
Contributor

Hi, I'd like to contribute to this repo.. Please let me know if I can contribute :)
As a small suggestion, perhaps the joke module could have genres, such as "knock knock", "walk into a bar", "meta", "puns", etc.
The user would interact by saying "tell me a knock knock joke". If no genre is mentioned, we just pick out a random one.

@swapagarwal
Copy link
Owner Author

You are welcome to contribute!
Only with the help from the community can this become something big.
I like the idea of having genres; I didn't implement it as I couldn't find relevant APIs.
Would you be interested to take this issue and make a list of category-wise good jokes?

@ghost
Copy link

ghost commented May 7, 2016

Hi what should be the deciding factor if a joke should be delivered by the API call or from the pre-compiled list within JARVIS?

@swapagarwal
Copy link
Owner Author

If we can hand-pick a minimum number (say 10-15) of funny jokes, then we'd remove the API call.

@ghost
Copy link

ghost commented May 8, 2016

But don't you think it would be just repeatedly showing these 10-15 only? I think we should make use of both of them.

@ghost
Copy link

ghost commented May 8, 2016

Also I propose we use a jokes.txt file for this list.

@swapagarwal
Copy link
Owner Author

swapagarwal commented May 8, 2016 •
edited
Loading

Those 10-15 can be expanded with time.
The problem with using an API is that sometimes, their jokes can be offensive to someone, so that's why we want hand-picked jokes!

@ghost
Copy link

ghost commented May 8, 2016

Understood. I'll submit some 10-15 for starters. We can expand later :)

@ghost
Copy link

ghost commented May 8, 2016

ss_joke
So this is how it's coming up!
If it's OK...I'll send a pull request. @swapagarwal

@ghost
Copy link

ghost commented May 8, 2016

I put a \t\t\t between the joke as a syntax for handling Q&A model jokes.

@swapagarwal
Copy link
Owner Author

@shanmukhateja You can send a PR and then we can take the discussion over there. 😄

swapagarwal pushed a commit that referenced this issue May 14, 2016
@shanmukhateja @swapagarwal
Remove API call in joke module (#35)
127f233 
See #4

* improve jokes module

* migrated to json format
@ghost
Copy link

ghost commented May 14, 2016

Now that this is resolved, shouldn't we close this issue @swapagarwal ?

@swapagarwal
Copy link
Owner Author

I'd like to keep this open for newbies to get started with (by adding some more jokes). 😄

@ghost
Copy link

ghost commented May 14, 2016

well then they can open a new one right? Like referencing the same issue multiple times for different commits by different ppl isn't much convincing
don't you think?

@ghost
Copy link

ghost commented May 14, 2016

They can just open a new issue later ;)

@swapagarwal
Copy link
Owner Author

Yepp, they can open a new one but keeping this open would encourage new people to start contributing!

@swapagarwal
Copy link
Owner Author

Continued in #54

@swapagarwal swapagarwal mentioned this issue Jun 21, 2017
Closed
edadesd pushed a commit to edadesd/JARVIS-on-Messenger that referenced this issue Jul 12, 2017
# This is a combination of 19 commits.
4ad772a 
# This is the 1st commit message:

Added more tests to test_anime

# This is the commit message swapagarwal#2:

Changed Hummingbird API to Kitsu
# This is the commit message swapagarwal#3:

Added bad query test to test_anime

# This is the commit message swapagarwal#4:

Based slice length on len

# This is the commit message swapagarwal#5:

Removed repeated searches.

# This is the commit message swapagarwal#6:

Broke tests into different functions.

# This is the commit message swapagarwal#7:

Removed whitespace.

# This is the commit message swapagarwal#8:

Added tests based on API response and rating format.

# This is the commit message swapagarwal#9:

Reorganized some calls.

# This is the commit message swapagarwal#10:

Refactored API requests, added tests for rank and episode count

# This is the commit message swapagarwal#11:

Added another test case.

# This is the commit message swapagarwal#12:

Added tests for kitsu and youtube links

# This is the commit message swapagarwal#13:

Stickler corrections.

# This is the commit message swapagarwal#14:

More Stickler corrections.

# This is the commit message swapagarwal#15:

More Stickler corrections.

# This is the commit message swapagarwal#16:

Stickler corrections.

# This is the commit message swapagarwal#17:

Moved declarations closer to point used.

# This is the commit message swapagarwal#18:

Style corrections.

# This is the commit message swapagarwal#19:

Style correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Improvement Low-Hanging Fruit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swapagarwal @havanagrawal