Add book module #11
Merged
Add book module #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,4 @@ | |||
| ACCESS_TOKEN = '<ACCESS_TOKEN>' | |||
| VERIFY_TOKEN = '<VERIFY_TOKEN>' | |||
| WIT_AI_ACCESS_TOKEN = 'IKJJJYYVR3X672DHFVS7U7C4L2MQSS2P' | |||
| GOODREADS_ACCESS_TOKEN = '<GOODREAD_ACCESS_TOKEN>' | |||
|
That is one awesome module you built there! |
swapagarwal
force-pushed
the
master
branch
2 times, most recently
from
70a69c4
to
656727f
Compare
|
Anything else I need to do here? |
|
Nope, looks perfect! (Sorry, I got caught up fixing a bug so I didn't see this earlier.) |
|
Deployed, and working as expected. Try it out with "anything you want book". |
edadesd
pushed a commit
to edadesd/JARVIS-on-Messenger
that referenced
this pull request
Jul 12, 2017
# This is the 1st commit message: Added more tests to test_anime # This is the commit message swapagarwal#2: Changed Hummingbird API to Kitsu # This is the commit message swapagarwal#3: Added bad query test to test_anime # This is the commit message swapagarwal#4: Based slice length on len # This is the commit message swapagarwal#5: Removed repeated searches. # This is the commit message swapagarwal#6: Broke tests into different functions. # This is the commit message swapagarwal#7: Removed whitespace. # This is the commit message swapagarwal#8: Added tests based on API response and rating format. # This is the commit message swapagarwal#9: Reorganized some calls. # This is the commit message swapagarwal#10: Refactored API requests, added tests for rank and episode count # This is the commit message swapagarwal#11: Added another test case. # This is the commit message swapagarwal#12: Added tests for kitsu and youtube links # This is the commit message swapagarwal#13: Stickler corrections. # This is the commit message swapagarwal#14: More Stickler corrections. # This is the commit message swapagarwal#15: More Stickler corrections. # This is the commit message swapagarwal#16: Stickler corrections. # This is the commit message swapagarwal#17: Moved declarations closer to point used. # This is the commit message swapagarwal#18: Style corrections. # This is the commit message swapagarwal#19: Style correction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is identical in structure and working to all the other ones.. Basically makes a call to the Goodreads API (You can sign up for a Goodreads Developer Key here
Small difference is that the api does not offer json output, so I've used some minor xml parsing to get the data.
Updates intents and entities on https://wit.ai/havanagrawal/JARVIS-on-Messenger
Sample output
