Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule based to NLP. Are you sure? #6

Closed
kunal15595 opened this issue Apr 21, 2016 · 2 comments
Closed

Rule based to NLP. Are you sure? #6

kunal15595 opened this issue Apr 21, 2016 · 2 comments
Labels
Question

Comments

@kunal15595
Copy link

You shifted from a rule based system to an online NLP based system. Is it a complete shift? This would mean that the system would not work offline. This would adversely affect in case of slow internet connection.
@swapagarwal
Copy link
Owner

Yes, it's a complete shift for now.
However, both the models reside independently in different branches (master and legacy) for any use.
For the system to work offline, the messenger server would have to be local which is not the case.
So, anyway, whenever you're messaging the bot, the processing is done server-side (whether it's rule based or NLP) so the client should not be affected by this.

@kunal15595
Copy link
Author

cool

edadesd pushed a commit to edadesd/JARVIS-on-Messenger that referenced this issue Jul 12, 2017
# This is a combination of 19 commits.
4ad772a 
# This is the 1st commit message:

Added more tests to test_anime

# This is the commit message swapagarwal#2:

Changed Hummingbird API to Kitsu
# This is the commit message swapagarwal#3:

Added bad query test to test_anime

# This is the commit message swapagarwal#4:

Based slice length on len

# This is the commit message swapagarwal#5:

Removed repeated searches.

# This is the commit message swapagarwal#6:

Broke tests into different functions.

# This is the commit message swapagarwal#7:

Removed whitespace.

# This is the commit message swapagarwal#8:

Added tests based on API response and rating format.

# This is the commit message swapagarwal#9:

Reorganized some calls.

# This is the commit message swapagarwal#10:

Refactored API requests, added tests for rank and episode count

# This is the commit message swapagarwal#11:

Added another test case.

# This is the commit message swapagarwal#12:

Added tests for kitsu and youtube links

# This is the commit message swapagarwal#13:

Stickler corrections.

# This is the commit message swapagarwal#14:

More Stickler corrections.

# This is the commit message swapagarwal#15:

More Stickler corrections.

# This is the commit message swapagarwal#16:

Stickler corrections.

# This is the commit message swapagarwal#17:

Moved declarations closer to point used.

# This is the commit message swapagarwal#18:

Style corrections.

# This is the commit message swapagarwal#19:

Style correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@swapagarwal @kunal15595