-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wiki module, another type of jokes, minor edits #9
Conversation
Thanks so much for taking the time to contribute! The And are the lib files required? I think we can do with I'm looking forward to merging this. 😄 |
@@ -31,4 +31,4 @@ def search(input): | |||
else: | |||
return 'Something didn\'t work as expected! I\'ll report this to my master.' | |||
else: | |||
return 'I\'m sorry; I\'m not sure I understand what you\'re trying to say sir.\nTry typing "help" or "request"' | |||
return 'I\'m sorry; I\'m not sure I understand what you\'re trying to say sir.\nTry typing "help" or "request"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Touch as few files as needed.
Thank you for your comments, @swapagarwal. I added |
Run |
I did |
Sure! 😄 |
|
# This is the 1st commit message: Added more tests to test_anime # This is the commit message swapagarwal#2: Changed Hummingbird API to Kitsu # This is the commit message swapagarwal#3: Added bad query test to test_anime # This is the commit message swapagarwal#4: Based slice length on len # This is the commit message swapagarwal#5: Removed repeated searches. # This is the commit message swapagarwal#6: Broke tests into different functions. # This is the commit message swapagarwal#7: Removed whitespace. # This is the commit message swapagarwal#8: Added tests based on API response and rating format. # This is the commit message swapagarwal#9: Reorganized some calls. # This is the commit message swapagarwal#10: Refactored API requests, added tests for rank and episode count # This is the commit message swapagarwal#11: Added another test case. # This is the commit message swapagarwal#12: Added tests for kitsu and youtube links # This is the commit message swapagarwal#13: Stickler corrections. # This is the commit message swapagarwal#14: More Stickler corrections. # This is the commit message swapagarwal#15: More Stickler corrections. # This is the commit message swapagarwal#16: Stickler corrections. # This is the commit message swapagarwal#17: Moved declarations closer to point used. # This is the commit message swapagarwal#18: Style corrections. # This is the commit message swapagarwal#19: Style correction
I added a wiki module but Wit.ai needs some training data. You would need to add a
wiki
Intent and aquery
entity. To verify that my code works without even tweaking Wit.ai, you may hardcode intent asmovie
and visithttp://localhost:5000/process/?q=movie%20happyness
. You should see Wikipedia results for Happiness.I also added a different variety of jokes to
joke.py
. I felt our community would appreciate diversity. I tried to look for APIs to get a random joke, but I could not find any free ones.Thank you!