Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki module, another type of jokes, minor edits #9

Merged
merged 5 commits into from
Apr 23, 2016

Conversation

ymittal
Copy link
Contributor

@ymittal ymittal commented Apr 22, 2016

I added a wiki module but Wit.ai needs some training data. You would need to add a wiki Intent and a query entity. To verify that my code works without even tweaking Wit.ai, you may hardcode intent as movie and visit http://localhost:5000/process/?q=movie%20happyness. You should see Wikipedia results for Happiness.

I also added a different variety of jokes to joke.py. I felt our community would appreciate diversity. I tried to look for APIs to get a random joke, but I could not find any free ones.

Thank you!

@swapagarwal
Copy link
Owner

swapagarwal commented Apr 22, 2016

Thanks so much for taking the time to contribute!
I'd really appreciate it if you could open another Pull Request for the joke module. (Stick to one module per PR 😄 ) The jokes definitely need to be as diverse as possible, and two APIs are better than one! 😜

The wiki module looks great! Just take a look at the lines that I have commented on. I have added the intent wiki so can you add some tests in the corresponding folder?

And are the lib files required? I think we can do with pip install wikipedia

I'm looking forward to merging this. 😄

@@ -31,4 +31,4 @@ def search(input):
else:
return 'Something didn\'t work as expected! I\'ll report this to my master.'
else:
return 'I\'m sorry; I\'m not sure I understand what you\'re trying to say sir.\nTry typing "help" or "request"'
return 'I\'m sorry; I\'m not sure I understand what you\'re trying to say sir.\nTry typing "help" or "request"'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Touch as few files as needed.

@ymittal
Copy link
Contributor Author

ymittal commented Apr 23, 2016

Thank you for your comments, @swapagarwal. I added lib/wikipedia to make sure that import wikipedia does not throw an error. wiki.py is not in root directory which is why I got an ImportError without the folder.

@swapagarwal
Copy link
Owner

Run pip install wikipedia
That way, the lib files won't be required, and you can simply use import wikipedia

@ymittal
Copy link
Contributor Author

ymittal commented Apr 23, 2016

I did pip install wikipedia. For some reason, I was receiving an ImportError until now. I have removed lib/wikipedia folder (yay).

@swapagarwal
Copy link
Owner


Are we ready to merge and deploy?

@ymittal
Copy link
Contributor Author

ymittal commented Apr 23, 2016

Sure! 😄

@swapagarwal swapagarwal merged commit dba514b into swapagarwal:master Apr 23, 2016
@swapagarwal
Copy link
Owner

swapagarwal commented Apr 23, 2016


Thanks @ymittal! 👍

edadesd pushed a commit to edadesd/JARVIS-on-Messenger that referenced this pull request Jul 12, 2017
# This is the 1st commit message:

Added more tests to test_anime

# This is the commit message swapagarwal#2:

Changed Hummingbird API to Kitsu
# This is the commit message swapagarwal#3:

Added bad query test to test_anime

# This is the commit message swapagarwal#4:

Based slice length on len

# This is the commit message swapagarwal#5:

Removed repeated searches.

# This is the commit message swapagarwal#6:

Broke tests into different functions.

# This is the commit message swapagarwal#7:

Removed whitespace.

# This is the commit message swapagarwal#8:

Added tests based on API response and rating format.

# This is the commit message swapagarwal#9:

Reorganized some calls.

# This is the commit message swapagarwal#10:

Refactored API requests, added tests for rank and episode count

# This is the commit message swapagarwal#11:

Added another test case.

# This is the commit message swapagarwal#12:

Added tests for kitsu and youtube links

# This is the commit message swapagarwal#13:

Stickler corrections.

# This is the commit message swapagarwal#14:

More Stickler corrections.

# This is the commit message swapagarwal#15:

More Stickler corrections.

# This is the commit message swapagarwal#16:

Stickler corrections.

# This is the commit message swapagarwal#17:

Moved declarations closer to point used.

# This is the commit message swapagarwal#18:

Style corrections.

# This is the commit message swapagarwal#19:

Style correction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants