Weather add #13
Weather add #13
Conversation
| <component name="VcsDirectoryMappings"> | ||
| <mapping directory="$PROJECT_DIR$" vcs="Git" /> | ||
| </component> | ||
| </project> |
There was a problem hiding this comment.
no need to check in this file
|
Hi @antixcode6, thank you for taking the time to add a new module. |
| @@ -1,3 +1,4 @@ | |||
| ACCESS_TOKEN = '<ACCESS_TOKEN>' | |||
| VERIFY_TOKEN = '<VERIFY_TOKEN>' | |||
| WIT_AI_ACCESS_TOKEN = 'IKJJJYYVR3X672DHFVS7U7C4L2MQSS2P' | |||
| OPEN_WEATHER_MAP_ACCESS_TOKEN = 'adee94563461cdf1dcfe25956aea10ae' | |||
There was a problem hiding this comment.
Replace the token with the placeholder, i've set it up on the server.
|
Whoa, that was fast! |
swapagarwal
force-pushed
the
master
branch
2 times, most recently
from
70a69c4
to
656727f
Compare
|
Worked on the further suggestions; was just curious if module was good to go |
| @@ -5,7 +5,6 @@ | |||
| from src import * | |||
|
|
|||
| WIT_AI_ACCESS_TOKEN = os.environ.get('WIT_AI_ACCESS_TOKEN', config.WIT_AI_ACCESS_TOKEN) | |||
|
|
|||
There was a problem hiding this comment.
add a blank line here to remove this file from diff
|
See here https://github.com/swapagarwal/JARVIS-on-Messenger/pull/13/files |
|
Why delete movie.py? |
|
Was just trying to remove it from this pull request since it had no place being there |
|
Can you make a new PR with changes only in the 3 required files? I think that'll be easier to merge. |
|
Alright I'm closing this I'll open a new one |
|
continued in #28 |
# This is the 1st commit message: Added more tests to test_anime # This is the commit message swapagarwal#2: Changed Hummingbird API to Kitsu # This is the commit message swapagarwal#3: Added bad query test to test_anime # This is the commit message swapagarwal#4: Based slice length on len # This is the commit message swapagarwal#5: Removed repeated searches. # This is the commit message swapagarwal#6: Broke tests into different functions. # This is the commit message swapagarwal#7: Removed whitespace. # This is the commit message swapagarwal#8: Added tests based on API response and rating format. # This is the commit message swapagarwal#9: Reorganized some calls. # This is the commit message swapagarwal#10: Refactored API requests, added tests for rank and episode count # This is the commit message swapagarwal#11: Added another test case. # This is the commit message swapagarwal#12: Added tests for kitsu and youtube links # This is the commit message swapagarwal#13: Stickler corrections. # This is the commit message swapagarwal#14: More Stickler corrections. # This is the commit message swapagarwal#15: More Stickler corrections. # This is the commit message swapagarwal#16: Stickler corrections. # This is the commit message swapagarwal#17: Moved declarations closer to point used. # This is the commit message swapagarwal#18: Style corrections. # This is the commit message swapagarwal#19: Style correction
No description provided.