Skip to content

Conversation

lkloh
Copy link
Contributor

@lkloh lkloh commented Mar 31, 2022

Description

@swift-nav/devinfra

Add a SbpMsgUnknown type to the sbp_msg_type_t enum for C++ messages so we have a way to initialize messages of undetermined type. This was first suggested here.

API compatibility

Does this change introduce a API compatibility risk?

No, this adds a message enum option but does not subtract or change anything already in use.

JIRA Reference

https://swift-nav.atlassian.net/browse/POS-559

@lkloh lkloh requested review from a team as code owners March 31, 2022 21:13
@lkloh lkloh changed the title [POS-557] [POS-559] Mar 31, 2022
@lkloh lkloh changed the title [POS-559] Add a SbpMsgUnknown type in for the sbp_msg_type_t enum [POS-559] Mar 31, 2022
@silverjam
Copy link
Contributor

@woodfell or @RReichert any concerns with this?

@lkloh lkloh requested review from woodfell and RReichert March 31, 2022 22:34
Copy link
Contributor

@woodfell woodfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@RReichert RReichert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lkloh lkloh merged commit d38f373 into master Apr 1, 2022
@lkloh lkloh deleted the lkloh/pos557 branch April 1, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants