Suppressed warnings and deprecation notices for Java #1107
Conversation
Adds @SuppressedWarning for unchecked generics and removes SBPStruct#parse return from generic to SBPStruct. Relates to DEVINFRA-479
| continue; | ||
| } catch (InterruptedException e) { | ||
| continue; | ||
| } catch (InterruptedException ignored) { |
There was a problem hiding this comment.
I think SonarCloud flagged this because you touched this line, if it makes sense we can just fix according to SonarCloud recommendation, if it doesn't make sense we can ignore the warning.
There was a problem hiding this comment.
hmm yea, maybe we could log the error as it suggests but is also another thing which the library doesn't look like it uses a logger instead using System.out.println() everywhere
I don't think it should have to throw an InterruptedException and it follows logically like previously:
https://github.com/swift-nav/libsbp/runs/2882927558
There was a problem hiding this comment.
I think we should ignore it (with // NOSONAR I think) and make a ticket to track switching to a logging facade
Description
@swift-nav/devinfra
Adds @SuppressedWarning for unchecked generics and removes SBPStruct#parse return from generic to SBPStruct.
Changes the concurrent for loop removing to maybe prevent ConcurrentModificationException (?) - not sure if needed, also it doesn't look like it was being called anyways
API compatibility
Does this change introduce a API compatibility risk?
It should not, it only suppresses warnings and narrowing the scope of return type
JIRA Reference
https://swift-nav.atlassian.net/browse/DEVINFRA-479