Skip to content

Suppressed warnings and deprecation notices for Java #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Suppressed warnings and deprecation notices for Java #1107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd23182
Suppressed warnings and deprecation notices for Java
adrian-kong Apr 6, 2022
274ddd8
Skip SONAR check
adrian-kong Apr 7, 2022
783447b
Java spotless fix
Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions java/src/com/swiftnav/sbp/SBPMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ protected void build(Builder builder) {
}

/** There is no exposed access to this class outside of libsbp. */
@SuppressWarnings("unchecked")
public class Parser {
private ByteBuffer buf;

Expand Down Expand Up @@ -212,11 +213,11 @@ public <T extends SBPStruct> T[] getArray(Class<T> t) {
LinkedList<T> l = new LinkedList<T>();
while (true) {
try {
T tmp = t.newInstance();
T tmp = t.getDeclaredConstructor().newInstance();
tmp.parse(this);
l.add(tmp);
} catch (BufferUnderflowException e) {
return (T[]) l.toArray((T[]) Array.newInstance(t, l.size()));
return l.toArray((T[]) Array.newInstance(t, l.size()));
} catch (Exception e) {
e.printStackTrace();
return null;
Expand All @@ -228,7 +229,7 @@ public <T extends SBPStruct> T[] getArray(Class<T> t, int n) {
T[] ret = (T[]) Array.newInstance(t, n);
for (int i = 0; i < n; i++) {
try {
ret[i] = t.newInstance();
ret[i] = t.getDeclaredConstructor().newInstance();
ret[i].parse(this);
} catch (Exception e) {
e.printStackTrace();
Expand Down
2 changes: 1 addition & 1 deletion java/src/com/swiftnav/sbp/SBPStruct.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ protected SBPStruct() {}

protected abstract void build(SBPMessage.Builder builder);

protected abstract <T> T parse(SBPMessage.Parser parser) throws SBPBinaryException;
protected abstract SBPStruct parse(SBPMessage.Parser parser) throws SBPBinaryException;

protected abstract JSONObject toJSON();

Expand Down
10 changes: 2 additions & 8 deletions java/src/com/swiftnav/sbp/client/SBPHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,7 @@ public void addCallbackMulti(int[] ids, Reference<SBPCallback> cb) {
public void removeCallback(SBPCallback cb) {
synchronized (callbacks) {
for (List<Reference<SBPCallback>> cblist : callbacks.values()) {
for (Reference<SBPCallback> ref : cblist) {
if (ref.get() == cb) {
cblist.remove(ref);
}
}
cblist.removeIf(ref -> ref.get() == cb);
}
strongCallbacks.remove(cb);
}
Expand Down Expand Up @@ -201,9 +197,7 @@ protected SBPMessage getNext() {
if (msg != null) {
return msg;
}
continue;
} catch (InterruptedException e) {
continue;
} catch (InterruptedException ignored) { // NOSONAR
}
}
// If we get here finished is set to true so there are no more messages available
Expand Down