Fixing unconsumed 4096 error sbp2json #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the suggested changes stops the unconsumed 4096 but runs for a long time, not sure how large the file is supposed to be generated but testing this change creates a 1gb json file for a 0.5gb sbp - runs for a long time (was interrupted) |
|
at some point we removed the JIT support for python and the bindings got really slow, so it might actually be working |
adrian-kong
changed the title
|
What is the behavior of the tool now? |
|
we were playing around with handler instead but that generated more messages than the rust version which was odd but the tool is fixed i think, it worked fine with the 10mb file without unconsumed 4096 |
|
i also made another pull request #1140 which takes out all the manual reading and also fixes the unconsumed 4096 |
adrian-kong
force-pushed
the
adrian/unconsumed4096
branch
from
5b5b2ef to
629554b
Compare
silverjam
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unconsumed 4096 error on sbp2json
JIRA Reference
https://swift-nav.atlassian.net/browse/DEVINFRA-510