Skip to content

Conversation

adrian-kong
Copy link
Contributor

Description

Refactors sbp2json to use inbuilt handler to parse file,

  • fixes the unconsumed 4096 but doesn't terminate because file doesn't get closed?
  • also needs to use that iter method to manually iterate through to maintain the order
  • also differs from the rust version because the float have 9 extra digits

JIRA Reference

https://swift-nav.atlassian.net/browse/DEVINFRA-510

@adrian-kong adrian-kong requested a review from a team as a code owner May 9, 2022 00:41
@notoriaga
Copy link
Contributor

  • also differs from the rust version because the float have 9 extra digits

I think that should be expected, python only has 64 bit floats and rust has 32 and 64 so I imagine you're looking at a field that is actually supposed to be a 32 bit float

@silverjam
Copy link
Contributor

Going to close this for now, we can re-open if we need to revisit this later

@silverjam silverjam closed this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants