Skip to content

Conversation

silverjam
Copy link
Contributor

@silverjam silverjam commented May 19, 2021

Second part of a two part fix for https://swift-nav.atlassian.net/browse/INFRA-477 -- similar to other -sys crates such as https://github.com/google/shaderc-rs/blob/master/shaderc-sys/build/build.rs -- set the CMAKE_INSTALL_PREFIX to the compile dir so that we don't need root access to run the install target.

@silverjam silverjam requested review from jbangelo and jayvdb May 19, 2021 01:21
@silverjam
Copy link
Contributor Author

silverjam commented May 19, 2021

The need for this was due to a change in https://github.com/swift-nav/libswiftnav submodule update, which came in from a cmake submodule update (I think)-- we could just revert the submodule pointer update for libswiftnav, but this change will come into libswiftnav at some point anyway (when we do the next open source drop).

@silverjam silverjam merged commit 40ad031 into master May 19, 2021
@silverjam silverjam deleted the silverjam/build-rs-install-fixup branch May 19, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants