-
Notifications
You must be signed in to change notification settings - Fork 128
Closed
Labels
area/performanceImprovements to performance.Improvements to performance.
Description
Just noticed that when just running loads of sequential super basic HTTP requests against a fast server (NIOHTTP1Server
), we spent about 7% of the overall runtime in HTTP1ClientChannelHandler.request.setter
which spends most of its time in _print_unlocked<A, B>(_:_:)
because it's pulling a debugDescription
for EventLoop for the logger metadata :P (release mode compile of course)
Should be an easy fix.
async-http-client/Sources/AsyncHTTPClient/ConnectionPool/HTTP1/HTTP1ClientChannelHandler.swift
Line 39 in 54d1006
requestLogger[metadataKey: "ahc-el"] = "\(self.eventLoop)" |

FWIW, the super basic perf test I used is this: weissi@bf7dbeb (this code isn't meant to be merged).
Metadata
Metadata
Assignees
Labels
area/performanceImprovements to performance.Improvements to performance.