Skip to content

test with thread sanitizer and check for api breakage in ci #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2019
Merged

test with thread sanitizer and check for api breakage in ci #122

merged 2 commits into from
Nov 5, 2019

Conversation

tomerd
Copy link
Contributor

@tomerd tomerd commented Oct 30, 2019

motivation: better ci testing

changes:

  • add api breakage script to test api breakage in ci
  • add "shell" utility docker-compose task to run api breakage script
  • change test task to treat warning as errors
  • change test task to use thread sanitizer in 5.1

@tomerd
test with thread sanitizer and check for api breakage in ci
29b2e7c 
motivation: better ci testing

changes:
* add api breakage script to test api breakage in ci
* add "shell" utility docker-compose task to run api breakage script
* change test task to treat warning as errors
* change test task to use thread sanitizer in 5.1
weissi
weissi approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@weissi weissi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@tomerd
Copy link
Contributor Author

tomerd commented Oct 30, 2019

@weissi unfortunately thread sanitizer fails:

[563/563] Linking async-http-clientPackageTests.xctest
ThreadSanitizer:DEADLYSIGNAL
==1517==ERROR: ThreadSanitizer: SEGV on unknown address 0xffffffffff700468 (pc 0x55fad9da80a8 bp 0x000000000018 sp 0x7ffdd5b1ead0 T1517)
==1517==The signal is caused by a READ memory access.
ThreadSanitizer:DEADLYSIGNAL
ThreadSanitizer: nested bug in the same thread, aborting.

any ideas why? works with docker on macOS

@tomerd tomerd added the 🔨 semver/patch No public API change. label Nov 5, 2019
@tomerd tomerd merged commit cbe6a53 into swift-server:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weissi weissi weissi approved these changes

Assignees
No one assigned
Labels
🔨 semver/patch No public API change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomerd @weissi