Solve incorrect "Show on GitHub" link #22
Conversation
|
Can one of the admins verify this patch? |
PopFlamingo
changed the title
There was a problem hiding this comment.
I'm not sure about the version thing, maybe @tomerd knows more.
|
thanks @adtrevor! can you rebase & squash so this has a single commit with the changes |
|
@tomerd Is this different from an admin directly merging it by choosing the squash and merge option? |
|
@adtrevor nope, but its hard to review the actual changes in this PR right now because of the noise, so its more to help the review |
|
I understand, thank you! Will do it when back on my computer.
… Le 30 avr. 2019 à 19:30, tomer doron ***@***.***> a écrit :
@adtrevor nope, but its hard to review the actual changes in this PR right now because of the noise, so its more to help the review
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@tomerd I did a soft reset to #fdb9dc10e5ac47e378b0d4c2278dd5dca858d7c3 followed by a commit using this method git reset --soft fdb9dc10e5ac47e378b0d4c2278dd5dca858d7c3
git commitYet there is still another commit and I'm not sure why the GitHub diff doesn't show the changes of this PR only. |
|
This time there only is one commit remaining, but the diff still shows more than I would hope... |
|
i think head is 44ddc8b |
This is a more correct way of versioning the docs and solves an issue where some of doc links would lead to a 404 GitHub page
|
@tomerd Thank you! I had used the wrong commit indeed! Done! 🙂 |
Since the package isn't tagged yet, the current file prefix URL isn't valid, causing the declarations "Go to GitHub" button to lead to a 404 page.