Split out @testable tests #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianpartridge
commented
Jun 24, 2019
Tests/LinuxMain.swift
Outdated
| @@ -27,6 +27,7 @@ import XCTest | |||
|
|
|||
| XCTMain([ | |||
| testCase(HTTPCookieTests.allTests), | |||
| testCase(SwiftHTTPInternalTests.allTests), | |||
There was a problem hiding this comment.
This is the new suite which requires @testable.
ianpartridge
commented
Jun 24, 2019
| import NIOSSL | ||
|
|
||
| class TestHTTPDelegate: HTTPClientResponseDelegate { | ||
| typealias Response = Void | ||
|
|
||
| var state = ResponseAccumulator.State.idle | ||
| enum State { |
There was a problem hiding this comment.
@testable was only required because we were piggy-backing on ResponseAccumulator.State. As we're not using the rest of ResponseAccumulator I think it's better to just define the state we need here.
ianpartridge
commented
Jun 24, 2019
|
|
||
| extension SwiftHTTPInternalTests { | ||
| static var allTests: [(String, (SwiftHTTPInternalTests) -> () throws -> Void)] { | ||
| return [ |
There was a problem hiding this comment.
These are the 5 tests which require @testable.
ianpartridge
commented
Jun 24, 2019
| @testable import NIOHTTP1 | ||
| @testable import NIOHTTPClient | ||
| import NIOSSL | ||
| import NIOHTTP1 |
There was a problem hiding this comment.
Clean up the imports while we're here. No need to use @testable on NIO modules.
ianpartridge
force-pushed
the
internal-tests
branch
from
3a8ad1f to
763cb05
Compare
|
That’s a great idea, thanks @ianpartridge . |
ianpartridge
force-pushed
the
internal-tests
branch
from
763cb05 to
f9c669c
Compare
|
Rebased, fixed conflicts, ready for review. |
artemredkin
reviewed
Jun 24, 2019
Tests/NIOHTTPClientTests/SwiftNIOHTTPInternalTests+XCTest.swift
Outdated
Show resolved
Hide resolved
|
One small question but otherwise looks good @ianpartridge, thanks! |
artemredkin
approved these changes
Jun 24, 2019
weissi
approved these changes
Jun 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the use of
@testable. Where it is required, use it from a separate testsuite so its usage is more explicit.