Assert that no two message types with the same name are registered #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
requested review from
aciidgh,
jakepetroules,
mirza-garibovic,
mhrawdon,
neonichu and
owenv
as code owners
|
@swift-ci Please test |
owenv
approved these changes
Aug 30, 2025
| } | ||
| #endif | ||
| for type in IPCMessage.messageTypes { | ||
| result[type.name] = type |
There was a problem hiding this comment.
@ahoppen nit: I would have suggested just doing it here, unconditionally (not behind DEBUG), rather than having a second loop:
if let oldValue = result.updateValue(type, forKey: type.name) {
fatalError("Multiple message types registered for same name: \(type.name)")
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies debugging issues that arise from accidentally trying to register multiple message types with the same name.