Skip to content

Assert that no two message types with the same name are registered #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2025
Merged

Assert that no two message types with the same name are registered #759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Sources/SWBProtocol/Message.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,6 +1222,14 @@ public struct IPCMessage: Serializable, Sendable {
/// Reverse name mapping.
static let messageNameToID: [String: any Message.Type] = {
var result = [String: any Message.Type]()
#if DEBUG
var seenMessageNames: Set<String> = []
for messageType in messageTypes {
if !seenMessageNames.insert(messageType.name).inserted {
assertionFailure("Multiple message types registered for same name: \(messageType.name)")
}
}
#endif
for type in IPCMessage.messageTypes {
result[type.name] = type
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahoppen nit: I would have suggested just doing it here, unconditionally (not behind DEBUG), rather than having a second loop:

if let oldValue = result.updateValue(type, forKey: type.name) {
    fatalError("Multiple message types registered for same name: \(type.name)")
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we go: #764

}
Expand Down