-
Notifications
You must be signed in to change notification settings - Fork 64
Change the tab-nav rendering to be v-show based #613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the tab-nav rendering to be v-show based #613
Conversation
Not opposed to switching to a |
Played a bit with tabnavs with lots of images found a few things. Behaviour is consistent across browsers, which is great. We explicitly set that images under the tabnav component should be eager loaded, so it downloads all images, rendered or not. This can deff cause slowdown on slower/limited networks. If we however change the |
@swift-ci test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
@swift-ci test |
@swift-ci test |
…//108379797 * refactor: change the tab-nav rendering rdar://108379797 * chore: add tests and cleanup --------- Co-authored-by: Hanqing Huang <87735557+hqhhuang@users.noreply.github.com>
Bug/issue #, if applicable: 108379797
Summary
Changes the TabNav content rendering to be v-show based, so images can be pre-loaded and wont flash when changing tabs.
Dependencies
NA
Testing
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test
, and it succeeded