Skip to content

Adds diff support to the sidebar #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dobromir-hristov
Copy link
Contributor

Bug/issue #, if applicable: 83858869

Summary

Adds basic diffing support to the sidebar

Dependencies

NA

Testing

NA

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary

Dobromir Hristov added 5 commits March 4, 2022 18:56
# Conflicts:
#	src/components/Navigator.vue
#	src/components/Navigator/NavigatorCard.vue
# Conflicts:
#	src/components/Navigator.vue
#	src/components/Navigator/NavigatorCard.vue
#	src/components/Navigator/NavigatorDataProvider.vue
#	src/views/DocumentationTopic.vue
Copy link
Contributor

@mportiz08 mportiz08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into issues blocking me from actually using and testing these changes, but I left an initial review on the code.

Dobromir Hristov added 2 commits March 10, 2022 11:09
# Conflicts:
#	src/components/Navigator.vue
#	src/components/Navigator/NavigatorCard.vue
@dobromir-hristov
Copy link
Contributor Author

@swift-ci test

@dobromir-hristov
Copy link
Contributor Author

@swift-ci test

@mportiz08 mportiz08 merged commit b1456a2 into swiftlang:main Mar 11, 2022
@mportiz08 mportiz08 deleted the dhristov/add-sidenav-diffs-v2 branch March 11, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants