Fix Windows build after 9413c59 #1298
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@d-ronnqvist It seems that #1292 broke the Windows toolchain build. Does the fix look reasonable to you? |
|
@swift-ci please test |
|
Yes, I think this would have been a reasonable fix. Unfortunately it was 10PM and #1299 was merged before this. |
Merged
|
Actually, it seems that this doesn't fully resolve the build issue. There's another issue with the initial handshake method not existing in Windows. |
|
Thank you for the quick revert. I guess we'll close here. Feel free to ping me on the reland PR if you need help with the Windows side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was behind an ifdef and got missed in the refactor