Do not fail the build on only finding incompatible-architecture modules on canImport queries
#84475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es on 'canImport' This change refactors the module loaders to explicitly take a parameter indicating whether or not the loader is handling a 'canImport' query, in order to avoid emitting an error when finding a dependency Swift binary module with only imcompatible architecture variants present. Resolves rdar://161175498
artemcm
requested review from
xymus,
bnbarham,
CodaFi,
DougGregor,
hamishknight and
rintaro
as code owners
|
@swift-ci test |
DougGregor
approved these changes
Sep 23, 2025
… swift binary module candidates Refactor 'maybeDiagnoseTargetMismatch' to separately collect mismatching target variant modules in 'identifyArchitectureVariants' and rename it to 'handlePossibleTargetMismatch'. Prior uses of 'maybeDiagnoseTargetMismatch' will continue diagnosing errors/warnings on only discovering incompatible swift binary module target variants. A new overload of 'handlePossibleTargetMismatch', in 'SwiftModuleScanner', instead collects it as a discovered incompatible candidate, for diagnosis downstream.
artemcm
force-pushed
the
NoCanImportFailOnWrongArch
branch
from
03e2eb4 to
48c2a32
Compare
|
@swift-ci smoke test |
|
swiftlang/swift-docc#1298 |
|
Been seeing this off and on for awhile, would love to see it fixed. 👍 |
|
@swift-ci test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two changes:
canImport.This change refactors the module loaders to explicitly take a parameter indicating whether or not the loader is handling a
canImportquery, in order to avoid emitting an error when finding a dependency Swift binary module with only incompatible architecture variants present.Refactor
maybeDiagnoseTargetMismatchto separately collect mismatching target variant modules inidentifyArchitectureVariantsand rename it tohandlePossibleTargetMismatch.Prior uses of
maybeDiagnoseTargetMismatchwill continue diagnosing errors/warnings on only discovering incompatible swift binary module target variants. A new overload ofhandlePossibleTargetMismatch, inSwiftModuleScanner, instead collects it as a discovered incompatible candidate, for diagnosis downstream.Resolves rdar://161175498