Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically opened by a GitHub action. Review the changes included in this PR and determine if they should be included in the release branch. If yes, merge the PR. Otherwise revert changes that should not be included on this branch.

glessard and others added 9 commits June 16, 2025 10:39
* Enable string conversion in EUC-JP.

Background: EUC-JP is not supported by OSS CoreFoundation, while it is supported by macOS Foundation Framework.
See #1016

This commit resolves the issue by calling ICU API if necessary.

* ICU: Omit encodings that should be supported by FoundationEssentials.

In response to: #1296 (comment)

* ICU: Remove unnecessary `nonisolated(unsafe)` from static property.

In response to: #1296 (comment)

* Add comment to `func _icuMakeStringFromBytes_impl`.

In response to: #1296 (comment)

* Delegate string conversion to ICU only when encoding is EUC-JP.

In response to: #1296 (comment)

* Replace dynamic `_icu*` functions only if `!FOUNDATION_FRAMEWORK`.

In response to: #1296 (comment)

* Divide test cases depending on `FOUNDATION_FRAMEWORK` for EUC_JP conversion.

In response to: #1296 (comment)
…sting (#1357)

* Convert predicate tests

* Convert ProcessInfo tests

* Convert String tests

* Convert RecurrenceRule tests

* Fix Windows build failure

* Fix build failures

* Avoid relying on default timezone
* Remove some workarounds

Remove conditional compilation statements put in place to work around a mismatch in the compiler version used by the Windows CI.

* Remove more workarounds

Remove conditional compilation statements put in place to work around a mismatch in the compiler version used by the Windows CI.
* Enable CI job to build via CMake

* Update cmake dependency branches for swift-foundation-icu and swift-syntax
* Convert DataIO tests

* Convert Data tests

* Move string path tests from Data IO suite to String suite

* Cleanup span expectations

* Fix build failure

* Fix watchOS build failure

* Move large data allocation tests into separate serialized suite
* Convert Gregorian Calendar tests

* Add Gregorian Calendar Internationalization suite
@jmschonfeld
Copy link
Contributor

@swift-ci please test

@jmschonfeld jmschonfeld marked this pull request as ready for review June 23, 2025 17:41
@jmschonfeld jmschonfeld requested review from itingliu and parkera June 23, 2025 17:41
@parkera parkera merged commit 7d9957d into release/6.2 Jun 23, 2025
4 checks passed
@parkera parkera deleted the automerge/merge-main-2025-06-23_09-02 branch June 23, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants