Improve URL component validation performance #1509
Merged
+186
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrflat
commented
Sep 12, 2025
| // MARK: - String Parsing | ||
|
|
||
| Benchmark("URL-ParseValidASCII") { benchmark in | ||
| Benchmark("URL.ParseValidASCII") { benchmark in |
There was a problem hiding this comment.
Changed the benchmark names to use . so they display better in the JMH visualizer.
|
@swift-ci please test |
jmschonfeld
approved these changes
Sep 15, 2025
tshortli
added a commit
to tshortli/swift-foundation
that referenced
this pull request
Sep 16, 2025
…ftlang#1509)" This reverts commit 02c0494.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During URL parsing, much of the time is spent validating the components in
UInt8.allowedURLComponents.getter. We can make this faster by using allowed bit masks per component rather than relying on a switch statement for theUInt8code units.The added test checks the validation behavior for all
UInt8code units in each URL component. The test passes before and after this change.20-25% speed up for parsing valid ASCII URLs: