Skip to content

Fix leadingDotSyntax test reliance on current internationalization preferences #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 1, 2025
Merged

Fix leadingDotSyntax test reliance on current internationalization preferences #1528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3173c28
Fix leadingDotSyntax test reliance on current i18n preferences
jmschonfeld Sep 29, 2025
f361cc2
Fix build failure
jmschonfeld Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions Tests/FoundationInternationalizationTests/Formatting/DateFormatStyleTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,23 +192,23 @@ private struct DateFormatStyleTests {
let locale = Locale(identifier: "es_ES")
await usingCurrentInternationalizationPreferences {
#expect(date.formatted(date: .long, time: .complete) == date.formatted(Date.FormatStyle(date: .long, time: .complete)))
}
#expect(
date.formatted(
.dateTime
.day()
.month()
.year()
.locale(locale)
) ==
date.formatted(
Date.FormatStyle()
.day()
.month()
.year()
.locale(locale)
#expect(
date.formatted(
.dateTime
.day()
.month()
.year()
.locale(locale)
) ==
date.formatted(
Date.FormatStyle()
.day()
.month()
.year()
.locale(locale)
)
)
)
}
}

@Test func dateFormatStyleIndividualFields() {
Expand Down
2 changes: 1 addition & 1 deletion Tests/FoundationInternationalizationTests/Formatting/DateIntervalFormatStyleTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ private struct DateIntervalFormatStyleTests {
// This test assumes both the left side and the right side of the comparison has the same `Locale.autoupdatingCurrent`, which assumes the state of the host machine remains unchanged.
#expect(range.formatted() == Date.IntervalFormatStyle().format(range))
#expect(range.formatted(date: .numeric, time: .shortened) == Date.IntervalFormatStyle(date: .numeric, time: .shortened).format(range))
#expect(range.formatted(.interval.day().month().year().locale(locale)) == Date.IntervalFormatStyle().day().month().year().locale(locale).format(range))
}

#expect(range.formatted(.interval.day().month().year().locale(locale)) == Date.IntervalFormatStyle().day().month().year().locale(locale).format(range))
}

#if FIXED_ICU_74_DAYPERIOD
Expand Down