CMake: modulemap override in build interface #1539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modulemap override should only be added in the build interface, where we don't copy the modulemap and header files. The install interface installs the modulemap and header files to a location where the compiler will see it, so passing the override results in the compiler seeing both modulemaps defining the same module and then failing. This moves the override to only be part of the build interface.
|
@swift-ci please test |
jmschonfeld
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modulemap override should only be added in the build interface, where we don't copy the modulemap and header files. The install interface installs the modulemap and header files to a location where the compiler will see it, so passing the override results in the compiler seeing both modulemaps defining the same module and then failing. This moves the override to only be part of the build interface.