Skip to content

Conversation

compnerd
Copy link
Member

Use ExternalProject to switch FoundationMacros to cross-compilation. This allows us to build the macros for the right OS/architecture when cross-compiling Foundation for other environments.

)

Use `ExternalProject` to switch FoundationMacros to cross-compilation.
This allows us to build the macros for the right OS/architecture when
cross-compiling Foundation for other environments.

Co-authored-by: Alex Lorenz <arphaman@gmail.com>
@compnerd
Copy link
Member Author

Explanation: Build changes necessary to support building macros for Windows.
Scope: Enables building and distributing the Foundation macros on all platforms.
Issue:
Original PR: #714
Risk: We would need additional changes to build and distribute the macros.
Testing: The original changes were tested as part of building the toolchain and the installer for Windows as well as the built image for Linux.
Reviewer: @jmschonfeld

@compnerd
Copy link
Member Author

@swift-ci please test

@jmschonfeld
Copy link
Contributor

Backporting this sounds like a good idea to me, let's just make sure that's ok with @etcwilde since his Musl PR also tries to address this, and let's also make sure we back port the swift repo changes (for build-script and build.ps1) and the installer script changes to install the macro on Windows

Copy link
Member

@etcwilde etcwilde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're waiting on me for approval, I'm fine with this. I just need a decision landed so that I can get the static SDK tipped back upright.

@compnerd compnerd merged commit eb3e4bc into swiftlang:release/6.0 Aug 15, 2024
@compnerd compnerd deleted the 60crosses branch August 15, 2024 22:10
kateinoigakukun added a commit to swiftwasm/swiftwasm-build that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants