WiX: Use uppercase for property names that are passed into the msi

[mhegazy]

MSI uses property name case to define scope. Public properties (i.e., can be set from outside the MSI, e.g., command line) are all uppercase, and ones set within the installer are lowercase. See more in the official docs

Since we are passing these properties to the MSI from the chainer, they need to be uppercase when they are being read. I have also changed the setting side to make sure we are consistent and do not run into this issue again.

Here is what the install log looks at runtime before this change:

MSI (s) (58:C8) [08:59:48:347]: Running product '{2873CAB4-2270-44BE-8A7E-FB17DB168601}' with user privileges: It's not assigned.
MSI (s) (58:C8) [08:59:48:347]: PROPERTY CHANGE: Adding INSTALLROOT property. Its value is 'C:\Users\mohamed.hegazy\AppData\Local\Programs\Swift'.
MSI (s) (58:C8) [08:59:48:347]: PROPERTY CHANGE: Adding INSTALLARM64SDK property. Its value is '1'.
MSI (s) (58:C8) [08:59:48:347]: PROPERTY CHANGE: Adding INSTALLARM64REDIST property. Its value is '1'.
MSI (s) (58:C8) [08:59:48:347]: PROPERTY CHANGE: Adding INSTALLAMD64SDK property. Its value is '1'.
MSI (s) (58:C8) [08:59:48:347]: PROPERTY CHANGE: Adding INSTALLAMD64REDIST property. Its value is '1'.
MSI (s) (58:C8) [08:59:48:347]: PROPERTY CHANGE: Adding INSTALLX86SDK property. Its value is '1'.
MSI (s) (58:C8) [08:59:48:347]: PROPERTY CHANGE: Adding INSTALLX86REDIST property. Its value is '1'.

[compnerd]

Please update the docs as well

[mhegazy]

Please update the docs as well

Do not think we expose any of the MSI properties in docs, do we?

[compnerd]

https://github.com/swiftlang/swift-installer-scripts/tree/main/platforms/Windows#install-directory-and-feature-selection exposes all the options

[compnerd]

Tested installer build: https://ci-external.swift.org/job/swift-PR-build-toolchain-windows/6145/artifact/build/artifacts/

[mhegazy]

@compnerd did a round of local testing and it passed with latest changes. can you please trigger another build

[mhegazy]

https://github.com/swiftlang/swift-installer-scripts/tree/main/platforms/Windows#install-directory-and-feature-selection exposes all the options

@compnerd these are the chainer options. these are options to the windows.msi that the chainer sets based on the public options. these are never exposed unless you msiexec the windows.msi directelly.

[compnerd]

Superseded by #468