WiX: Fix MSI custom properties #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MSI properties must be in CAPS_LOCK or they do not work properly. * They must be introduced with a default value. * Features should default to being installable (`Level=1`) and the override should set `Level` to 0 to skip installation of features. This is to prevent issues with uninstallation.
|
@swift-ci please test |
Steelskin
requested review from
compnerd,
etcwilde and
shahmishal
as code owners
|
The resulting build works "fine" but a missing DLL prevents the installation from being functional. This is fixed in #469. |
compnerd
reviewed
Oct 7, 2025
There was a problem hiding this comment.
Case correction is the core of the change.
The handling of the levels is related to fixing the uninstall behaviour - the MSI must be invoked with the same property set on uninstall to take effect. We invert the values to get the proper behaviour. Level defaults to 1, and we set the value to 0 for the case where the SDK slice should be skipped.
The default values of the properties seem incorrect - we should default to these enabled.
This also tweaks the installer to also install the corresponding Experimental SDK on Windows.
compnerd
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Level=1) and the override should setLevelto 0 to skip installation of features. This is to prevent issues with uninstallation.