Rename runCommandPlugins methods to a more accurate name #9223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcgee1024
requested review from
jakepetroules,
dschaefer2,
shawnhyam,
bripeticca,
plemarquand,
owenv,
bkhouri,
daveyc123 and
rconnell9
as code owners
|
@swift-ci please test |
owenv
approved these changes
Oct 6, 2025
|
@swift-ci test macOS |
|
@swift-ci test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is very confusing because it suggests that command plugins will be run during build, which is not the case. Command plugins always run at the user's request using
swift package plugin <name>outside of a build.Instead, this method should be renamed to reflect that it is running commands that the plugin has generated when it was invoked from a collection of results.
Rename the methods in both the SwiftBuildSupport and Build components and update the documentation.