Skip to content

Rename runCommandPlugins methods to a more accurate name #9223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

Rename runCommandPlugins methods to a more accurate name #9223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Sources/Build/BuildPlan/BuildPlan.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ public class BuildPlan: SPMBuildCore.BuildPlan {
}

buildToolPluginInvocationResults[module.id] = pluginInvocationResults
prebuildCommandResults[module.id] = try Self.runCommandPlugins(
prebuildCommandResults[module.id] = try Self.runPluginCommands(
using: pluginConfiguration,
for: pluginInvocationResults,
fileSystem: fileSystem,
Expand Down Expand Up @@ -854,9 +854,9 @@ extension BuildPlan {
return buildToolPluginResults
}

/// Runs any command plugins associated with the given list of plugin invocation results,
/// Runs any commands associated with the given list of plugin invocation results,
/// in order, and returns the results of running those prebuild commands.
fileprivate static func runCommandPlugins(
fileprivate static func runPluginCommands(
using pluginConfiguration: PluginConfiguration,
for pluginResults: [BuildToolPluginInvocationResult],
fileSystem: any FileSystem,
Expand Down
6 changes: 3 additions & 3 deletions Sources/SwiftBuildSupport/PIFBuilder.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ public final class PIFBuilder {

// Run the prebuild commands generated from the plugin invocation now for this module. This will
// also give use the derived source code files needed for PIF generation.
let runResults = try Self.runCommandPlugins(
let runResults = try Self.runPluginCommands(
using: self.pluginConfiguration,
for: buildToolPluginResults,
fileSystem: fileSystem,
Expand Down Expand Up @@ -429,9 +429,9 @@ public final class PIFBuilder {
}
}

/// Runs any command plugins associated with the given list of plugin invocation results,
/// Runs any commands associated with the given list of plugin invocation results,
/// in order, and returns the results of running those prebuild commands.
fileprivate static func runCommandPlugins(
fileprivate static func runPluginCommands(
using pluginConfiguration: PluginConfiguration,
for pluginResults: [BuildToolPluginInvocationResult],
fileSystem: any FileSystem,
Expand Down