Skip to content

Promote Darwin image attachments to API. #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 27, 2025
Merged

Promote Darwin image attachments to API. #1274

merged 15 commits into from
Aug 27, 2025

Conversation

grynspan
Copy link
Contributor

@grynspan grynspan commented Aug 18, 2025 •
edited
Loading

This PR promotes image attachments on Apple platforms to API (pending approval of ST-0014).

Resolves rdar://154869188.
Resolves rdar://154869124.
Resolves rdar://154869071.

Checklist:

  • Code and documentation should follow the style of the Style Guide.
  • If public symbols are renamed or modified, DocC references should be updated.

@grynspan
Promote Darwin image attachments to API.
b59e4b2 
This PR promotes image attachments on Apple platforms to API (pending approval
of ST-0014).
@grynspan grynspan added this to the Swift 6.x (main) milestone Aug 18, 2025
@grynspan grynspan self-assigned this Aug 18, 2025
@grynspan grynspan added darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support public-api Affects public API attachments/activities 🖇️ Work related to attachments and/or activities labels Aug 18, 2025
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan mentioned this pull request Aug 19, 2025
Draft
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

stmontgomery
stmontgomery reviewed Aug 20, 2025
View reviewed changes
stmontgomery
stmontgomery reviewed Aug 20, 2025
View reviewed changes
stmontgomery
stmontgomery reviewed Aug 20, 2025
View reviewed changes
@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan
Copy link
Contributor Author

@swift-ci test

@grynspan grynspan requested a review from stmontgomery August 26, 2025 11:27
@grynspan grynspan marked this pull request as ready for review August 26, 2025 11:27
jerryjrchen
jerryjrchen reviewed Aug 26, 2025
View reviewed changes
@grynspan grynspan merged commit 78f6ced into main Aug 27, 2025
3 checks passed
@grynspan grynspan deleted the jgrynspan/enable-darwin-image-attachments branch August 27, 2025 18:48
@grynspan grynspan added the image-attachments 📸 Work related to image attachments label Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryjrchen jerryjrchen jerryjrchen left review comments

@stmontgomery stmontgomery stmontgomery approved these changes

@briancroom briancroom Awaiting requested review from briancroom briancroom is a code owner

@suzannaratcliff suzannaratcliff Awaiting requested review from suzannaratcliff suzannaratcliff is a code owner

Assignees

@grynspan grynspan

Labels
attachments/activities 🖇️ Work related to attachments and/or activities darwin 🍎 macOS, iOS, watchOS, tvOS, and visionOS support image-attachments 📸 Work related to image attachments public-api Affects public API
Projects
None yet
Milestone
Swift 6.x (main)
Development

Successfully merging this pull request may close these issues.
3 participants
@grynspan @stmontgomery @jerryjrchen