-
Notifications
You must be signed in to change notification settings - Fork 124
Promote Darwin image attachments to API. #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b59e4b2
Promote Darwin image attachments to API.
grynspan 596a879
Merge branch 'main' into jgrynspan/enable-darwin-image-attachments
grynspan 6771573
Don't comment out Windows support in the experimental Windows overlay…
grynspan 00ca245
Remove another @_spi
grynspan 9b4887f
Update CMake
grynspan 387878f
Enable library evolution
grynspan b87a69f
Add more linked libraries to CMake
grynspan 641d679
Update .swiftcrossimport folder
grynspan 16708c2
CMake doesn't like comments there
grynspan 546b183
Merge branch 'main' into jgrynspan/enable-darwin-image-attachments
grynspan 7d8f804
Fix typo
grynspan e21c8bd
CG cmake fixes
grynspan 9df7af3
Fix CMake typo
grynspan 790d22a
Specify weak framework the CMake way
grynspan ee2ffe0
Rely on autolinking for framework dependencies
grynspan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,13 @@ | ||
# This source file is part of the Swift.org open source project | ||
# | ||
# Copyright (c) 2024 Apple Inc. and the Swift project authors | ||
# Copyright (c) 2024–2025 Apple Inc. and the Swift project authors | ||
# Licensed under Apache License v2.0 with Runtime Library Exception | ||
# | ||
# See http://swift.org/LICENSE.txt for license information | ||
# See http://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
|
||
add_subdirectory(_Testing_AppKit) | ||
add_subdirectory(_Testing_CoreGraphics) | ||
add_subdirectory(_Testing_CoreImage) | ||
add_subdirectory(_Testing_Foundation) | ||
add_subdirectory(_Testing_UIKit) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# This source file is part of the Swift.org open source project | ||
# | ||
# Copyright (c) 2024–2025 Apple Inc. and the Swift project authors | ||
# Licensed under Apache License v2.0 with Runtime Library Exception | ||
# | ||
# See http://swift.org/LICENSE.txt for license information | ||
# See http://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
|
||
if (CMAKE_SYSTEM_NAME STREQUAL "Darwin") | ||
add_library(_Testing_AppKit | ||
Attachments/NSImage+AttachableAsCGImage.swift | ||
ReexportTesting.swift) | ||
|
||
target_link_libraries(_Testing_AppKit PUBLIC | ||
Testing | ||
_Testing_CoreGraphics) | ||
|
||
target_compile_options(_Testing_AppKit PRIVATE | ||
-enable-library-evolution | ||
-emit-module-interface -emit-module-interface-path $<TARGET_PROPERTY:_Testing_AppKit,Swift_MODULE_DIRECTORY>/_Testing_AppKit.swiftinterface) | ||
|
||
_swift_testing_install_target(_Testing_AppKit) | ||
endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2024 Apple Inc. and the Swift project authors | ||
// Copyright (c) 2024–2025 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// See https://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
// | ||
|
||
@_exported @_spi(Experimental) @_spi(ForToolsIntegrationOnly) public import Testing | ||
@_exported @_spi(Experimental) @_spi(ForToolsIntegrationOnly) public import _Testing_CoreGraphics | ||
@_exported public import Testing | ||
@_exported public import _Testing_CoreGraphics |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
# This source file is part of the Swift.org open source project | ||
# | ||
# Copyright (c) 2024–2025 Apple Inc. and the Swift project authors | ||
# Licensed under Apache License v2.0 with Runtime Library Exception | ||
# | ||
# See http://swift.org/LICENSE.txt for license information | ||
# See http://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
|
||
if(APPLE) | ||
add_library(_Testing_CoreGraphics | ||
Attachments/_AttachableImageWrapper+AttachableWrapper.swift | ||
Attachments/AttachableAsCGImage.swift | ||
Attachments/AttachableImageFormat+UTType.swift | ||
Attachments/Attachment+AttachableAsCGImage.swift | ||
Attachments/CGImage+AttachableAsCGImage.swift | ||
ReexportTesting.swift) | ||
|
||
target_link_libraries(_Testing_CoreGraphics PUBLIC | ||
Testing) | ||
|
||
target_compile_options(_Testing_CoreGraphics PRIVATE | ||
-enable-library-evolution | ||
-emit-module-interface -emit-module-interface-path $<TARGET_PROPERTY:_Testing_CoreGraphics,Swift_MODULE_DIRECTORY>/_Testing_CoreGraphics.swiftinterface) | ||
|
||
_swift_testing_install_target(_Testing_CoreGraphics) | ||
endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2024 Apple Inc. and the Swift project authors | ||
// Copyright (c) 2024–2025 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// See https://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
// | ||
|
||
@_exported @_spi(Experimental) @_spi(ForToolsIntegrationOnly) public import Testing | ||
@_exported public import Testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
# This source file is part of the Swift.org open source project | ||
# | ||
# Copyright (c) 2024–2025 Apple Inc. and the Swift project authors | ||
# Licensed under Apache License v2.0 with Runtime Library Exception | ||
# | ||
# See http://swift.org/LICENSE.txt for license information | ||
# See http://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
|
||
if(APPLE) | ||
add_library(_Testing_CoreImage | ||
Attachments/CIImage+AttachableAsCGImage.swift | ||
ReexportTesting.swift) | ||
|
||
target_link_libraries(_Testing_CoreImage PUBLIC | ||
Testing | ||
_Testing_CoreGraphics) | ||
|
||
target_compile_options(_Testing_CoreImage PRIVATE | ||
-enable-library-evolution | ||
-emit-module-interface -emit-module-interface-path $<TARGET_PROPERTY:_Testing_CoreImage,Swift_MODULE_DIRECTORY>/_Testing_CoreImage.swiftinterface) | ||
|
||
_swift_testing_install_target(_Testing_CoreImage) | ||
endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,12 @@ | ||
// | ||
// This source file is part of the Swift.org open source project | ||
// | ||
// Copyright (c) 2024 Apple Inc. and the Swift project authors | ||
// Copyright (c) 2024–2025 Apple Inc. and the Swift project authors | ||
// Licensed under Apache License v2.0 with Runtime Library Exception | ||
// | ||
// See https://swift.org/LICENSE.txt for license information | ||
// See https://swift.org/CONTRIBUTORS.txt for Swift project authors | ||
// | ||
|
||
@_exported @_spi(Experimental) @_spi(ForToolsIntegrationOnly) public import Testing | ||
@_exported @_spi(Experimental) @_spi(ForToolsIntegrationOnly) public import _Testing_CoreGraphics | ||
@_exported public import Testing | ||
@_exported public import _Testing_CoreGraphics |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.