Skip to content

Lazy accessor synthesis for storage in primary files #26469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 7, 2019
Merged

Lazy accessor synthesis for storage in primary files #26469

merged 5 commits into from
Aug 7, 2019

Conversation

slavapestov
Copy link
Contributor

This is a follow-up to #26461. It introduces new methods on AbstractStorageDecl for visiting accessors in a deterministic way, intended to replace getAllAccessors():

  • visitParsedAccessors() - visits parsed accessors only
  • visitEmittedAccessors() - visits parsed and opaque accessors

This facilitates the removal of addExpectedOpaqueAccessorsToStorage().

@slavapestov slavapestov force-pushed the lazy-accessor-synthesis-part-2 branch from e9885de to e3e07d0 Compare August 3, 2019 02:40
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@swift-ci Please test compiler performance

@swift-ci
Copy link
Contributor

swift-ci commented Aug 3, 2019

Build failed
Swift Test OS X Platform
Git Sha - e3e07d07e55855f9a5ad82b8c29d4c268740f126

@swift-ci
Copy link
Contributor

swift-ci commented Aug 3, 2019

Build failed
Swift Test Linux Platform
Git Sha - e3e07d07e55855f9a5ad82b8c29d4c268740f126

@swift-ci
Copy link
Contributor

swift-ci commented Aug 3, 2019

Compilation-performance test failed

rjmccall
rjmccall reviewed Aug 6, 2019
View reviewed changes
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor requests only

include/swift/AST/Decl.h Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Eagerly" emitted accessors, maybe?

lib/Sema/TypeCheckAttr.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typo in the comment while you're here.

lib/Sema/TypeCheckDecl.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"in elsewhere"

@slavapestov slavapestov force-pushed the lazy-accessor-synthesis-part-2 branch from e3e07d0 to 2b6a672 Compare August 6, 2019 20:31
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

swift-ci commented Aug 6, 2019

Build failed
Swift Test OS X Platform
Git Sha - e3e07d07e55855f9a5ad82b8c29d4c268740f126

@swift-ci
Copy link
Contributor

swift-ci commented Aug 6, 2019

Build failed
Swift Test Linux Platform
Git Sha - e3e07d07e55855f9a5ad82b8c29d4c268740f126

@slavapestov
AST: Fix mangling of unvalidated declarations
2e3f4ac 
This is again just a temporary workaround until getInterfaceType() can
kick off a request.
@slavapestov
AST: Slightly more efficient requiresNewVTableEntry()
05baaa8
@slavapestov slavapestov force-pushed the lazy-accessor-synthesis-part-2 branch from 2b6a672 to 05baaa8 Compare August 6, 2019 21:58
@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility

@slavapestov slavapestov mentioned this pull request Aug 6, 2019
Merged
@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility debug

2 similar comments
@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility debug

@slavapestov
Copy link
Contributor Author

@swift-ci Please test source compatibility debug

@slavapestov slavapestov merged commit b60f4ed into swiftlang:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjmccall rjmccall rjmccall left review comments

@DougGregor DougGregor Awaiting requested review from DougGregor

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slavapestov @swift-ci @rjmccall