Re-organize some code in lib/Sema/ #26519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Note that I'm merging #26469 first) |
slavapestov
force-pushed
the
type-check-storage-cleanup
branch
2 times, most recently
from
b7027a4 to
b30f373
Compare
|
@swift-ci Please smoke test |
…ynthesis.cpp This was split between the two files; consolidate it in CodeSynthesis.cpp.
slavapestov
force-pushed
the
type-check-storage-cleanup
branch
from
b30f373 to
c3b6fd1
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new file, TypeCheckStorage.cpp, consolidating code from TypeCheckDecl.cpp and CodeSynthesis.cpp related to property, subscript and accessor validation. Also, this moves some code related to implicit constructor synthesis from TypeCheckDecl.cpp to CodeSynthesis.cpp.