[32bits] Update assert on SymbolicValue size #27515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the storage is a multiple of uint64_t (derived by what LLVM's APInt does) we want to check for 2*uin64_t here, even on 32bit platforms.
jrose-apple
reviewed
Oct 3, 2019
| static_assert(sizeof(SymbolicValue) == 2 * sizeof(void *), | ||
| static_assert(sizeof(SymbolicValue) == 2 * sizeof(uint64_t), | ||
| "SymbolicValue should stay small"); | ||
| static_assert(std::is_pod<SymbolicValue>::value, |
There was a problem hiding this comment.
@marcrasi While here, I suggest changing this to is_trivially_copyable or is_trivial or is_standard_layout, whichever is actually being relied upon. See https://en.cppreference.com/w/cpp/named_req/PODType for more details.
marcrasi
approved these changes
Oct 3, 2019
|
@swift-ci Please smoke test and merge |
|
Same |
|
swiftlang/swift-corelibs-foundation#2532 |
|
@swift-ci Please smoke test Linux |
1 similar comment
|
@swift-ci Please smoke test Linux |
|
Sorry for the delay! |
|
No problem 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the storage is a multiple of uint64_t (following what LLVM's APInt does, copy implemented here) we want to check for 2*uin64_t here, even on 32bit platforms.
Right now, this breaks 5.1 builds on 32bits(arm&co).