Skip to content

[32bits] Update assert on SymbolicValue size #27515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019
Merged

[32bits] Update assert on SymbolicValue size #27515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/swift/SIL/SILConstants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,7 +556,7 @@ class SymbolicValue {
void dump() const;
};

static_assert(sizeof(SymbolicValue) == 2 * sizeof(void *),
static_assert(sizeof(SymbolicValue) == 2 * sizeof(uint64_t),
"SymbolicValue should stay small");
static_assert(std::is_pod<SymbolicValue>::value,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marcrasi While here, I suggest changing this to is_trivially_copyable or is_trivial or is_standard_layout, whichever is actually being relied upon. See https://en.cppreference.com/w/cpp/named_req/PODType for more details.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a PR: #27521

"SymbolicValue should stay POD");
Expand Down